Exclude unused dependencies to reduce file size #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lognaturel
force-pushed
the
dep-exclude
branch
from
1d04908
to
ba7f3a7
Compare
lognaturel
changed the title
lognaturel
changed the title
yanokwa
approved these changes
Sep 9, 2024
lognaturel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress to #92, down to 3.9 MB
What has been done to verify that this works as intended?
Ran the resulting jar, validated some forms. Thought about ways geoJSON is used to confirm they require an external file.
Used
java -verbose:classto identify bouncycastle classes actually used for form extract-signed.xml.zipWhy is this the best possible solution? Were any other approaches considered?
It isn't needed so let's remove. I initially thought I could also remove the CSV dependency but it's currently used.
Are there any risks to merging this code? If so, what are they?
Those libs could be used in ways that I haven't anticipated. Risk is limited to
extract-signedand geojson which are advanced features.